LED on ethernet ports not working - R4 with Debian 6.12

thesnake · January 30, 2025, 12:32pm

Hello everybody.

I have a strange problem. On my R4 board the green/yellow LED on the 4 ethernet ports always remain dark when using Debian (6.12.8-bpi-r4-main bullseye from frank-w). The ports do work and connect correclty though. Under OpenWRT the LED light up correctly showing link status and activity.

Is it only me, or do others face that problem as well?

Thanks

Peter

frank-w · January 30, 2025, 2:15pm

Possibly i miss the ethernet-led definitions in my r4 dts…or missing driver in defconfig. Did not worked much over the rj45 ports in last time.

thesnake · January 31, 2025, 9:25am

Good morning Frank,

do you have a hint for me where to look for this in the dts?

I note that the ethernet LED’s are exposed under /sys/class/leds/, that doesn’t seem correct. It is not possible to switch them on or off using the brightness or other settings there.

ls /sys/class/leds/

blue:wps green:status mt7530-0:00:green:lan mt7530-0:01:green:lan mt7530-0:02:green:lan mt7530-0:03:green:lan

Thanks and have a good day!

frank-w · January 31, 2025, 11:58am

i can confirm, that rj45-leds are not working in my kernel

dts contains leds subnodes (also enabled and assigned to pinctrl in the board dts)

github.com

frank-w/BPI-Router-Linux/blob/6.13-main/arch/arm64/boot/dts/mediatek/mt7988a.dtsi#L1228


      
          				mediatek,pio = <&pio>;
          
          				gsw_phy0: ethernet-phy@0 {
          					compatible = "ethernet-phy-ieee802.3-c22";
          					reg = <0>;
          					interrupts = <0>;
          					phy-mode = "internal";
          					nvmem-cells = <&phy_calibration_p0>;
          					nvmem-cell-names = "phy-cal-data";
          
          					leds {
          						#address-cells = <1>;
          						#size-cells = <0>;
          
          						gsw_phy0_led0: gsw-phy0-led0@0 {
          							reg = <0>;
          							function = LED_FUNCTION_LAN;
          							status = "disabled";
          						};
          
          						gsw_phy0_led1: gsw-phy0-led1@1 {

neither mt7530 dsa driver does something with leds nor the ethernet driver…seems like handled in core (e.g. phylib)…so i tried adding CONFIG_LED_TRIGGER_PHY=y, without success

frank-w · January 31, 2025, 6:20pm

with the help from @dangowrt i got it working again, could you please try 6.13-main for confirmation?

79e1c255f013 2025-01-31 arm64: dts: add syscon fallback for ethernet-leds Frank Wunderlich  (HEAD -> 6.13-main, origin/6.13-main)
ed23ff9d2966 2025-01-31 defconfig: r4: try to fix ethernet-leds (not enough yet) Frank Wunderlich

mytratom · January 31, 2025, 9:14pm

I can confirm this happened to me too in 6.12.11

I’ll check out FrankW’s patch a little bit later today.

thesnake · February 3, 2025, 10:27am

Thanks a lot Frank, i will try later.

frank-w · February 3, 2025, 11:35am

Possibly the patch is not needed on 6.14+ as the handling of syscon nodes changed a bit