Is there a way setup vlan for eth1(left SFP port) for BPI-R3

Halry · April 4, 2024, 4:02am

Tried to set up gpon stick for bpi-r3 which required me set eth1 with vlan 41, however, it just won’t work. I read frank-w’s website it says eth1 doesn’t support vlan in linux 6.1. Is there any other way to use eth1 with vlan? Or will it be fixed in linux 6.6 as snapshot start to use linux 6.6 for testing now.

And the sfp port with mt7531 is working fine, but i need sfp1 to connect my 2.5gbe switch.

frank-w · April 4, 2024, 6:20am

Which system (image,kernel) do you use? Afair i ported a fix and it should be upstreamed in 6.1. sfp2 (port5 of switch,lan4) was afair working so you could use this…just make sure it is not in lanbr

Seems vlan fix was not backported to 6.1

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/net/ethernet/mediatek/mtk_eth_soc.c?h=linux-6.6.y&id=c6d96df9fa2c1d19525239d4262889cce594ce6c

Halry · April 4, 2024, 6:47am

Using openwrt SNAPSHOT r25591-362f9c41a4 which is based on 6.1.82.

That’s too bad, my ISP also provides IPTV which also using vlan tagging therefore I have to bridge it with LAN port together in order to use IPTV. So it seems I have to stick with sfp1 at this moment. Thanks for your information.

frank-w · April 4, 2024, 7:01am

You could try backport the patch yourself,seems i miss it into my tree too

Maybe disabling in hardware helps:

github.com

frank-w/BPI-Router-Linux/blob/6.1-main/drivers/net/ethernet/mediatek/mtk_eth_soc.c#L3353


      
          		}
          	}
          
          	/* Indicates CDM to parse the MTK special tag from CPU
          	 * which also is working out for untag packets.
          	 */
          	val = mtk_r32(eth, MTK_CDMQ_IG_CTRL);
          	mtk_w32(eth, val | MTK_CDMQ_STAG_EN, MTK_CDMQ_IG_CTRL);
          
          	/* Enable RX VLan Offloading */
          	mtk_w32(eth, 1, MTK_CDMP_EG_CTRL);
          
          	/* set interrupt delays based on current Net DIM sample */
          	mtk_dim_rx(&eth->rx_dim.work);
          	mtk_dim_tx(&eth->tx_dim.work);
          
          	/* disable delay and normal interrupt */
          	mtk_tx_irq_disable(eth, ~0);
          	mtk_rx_irq_disable(eth, ~0);
          
          	/* FE int grouping */

Just commenting it out

frank-w · April 6, 2024, 8:09am

Have you tested it?

Felix’ patch has fixed tag for later commit where he made vlan offload configurable by ethtool, but the breaking code was there before.

Maybe we can send a patch fixing 6.1 too…just confirm disabling this line works.if not we have to dig further.

Halry · April 8, 2024, 5:10pm

Sorry, I am not at home during workday, I will test it as soon as I get home.

frank-w · April 15, 2024, 6:07am

Have you checked it on weekend?

frank-w · April 27, 2024, 7:30am

@halry any new state?

jcdutton · April 27, 2024, 4:19pm

Hi,

Regarding VLANs. VLANs work on SFP1 and SFP2. I have tested and the following works:

No traffic on untagged. Commonly referred to as the P-VLAN, I set this to 99.
VLAN 1 tagged (br-lan)
VLAN 5 tagged. (br-guest)

When doing VLANs, I found that the BPI-R3 had problems if you tried to send/receive traffic on the untagged VLAN while also trying to send traffic on tagged vlans. I.e. VLAN 1 and 5 work, VLAN 99 fails to pass traffic.

frank-w · April 27, 2024, 4:26pm

Afair the problem is with vlan offloading because one mac is connected to switch (dsa tags for portmapping). So the traffic on the other mac without switch also strips vlan-tags…

Sfp-lan should not be affected on r3 as this is routed over mt7531 and gets dsa tags on top of vlan tag. Imho the issues is only on sfp-wan which is directly connected to mac

Have you tried disabling the line i pointed above (to disable vlan offloading)?

Halry · May 1, 2024, 11:22am

Sorry for the late reply, I was able to compile the firmware today(finally the labour day holiday ) and have a preliminary test, it seems okay for this moment(at least the bridge and the wifi seems ok). I have aggregated all ports together and then use the bridge VLAN filter to divide the Guest VLAN and the home VLAN, then the WAN SFP port connects to the switch and the LAN 1 port connects to the next AP, it seems fine right now. Both can work under AP mode. Also seems your method can apply on other filogic routers that use both GMAC 0 and 1 for 2.5Gbps ports (in my case is XDR6088 and MT6000). Haven’t tested if the speed will compromise, but at least they work at this moment.

Thank you so much.

frank-w · May 1, 2024, 5:58pm

So vlan bug fixed so far? Good to know. Thx

Halry · May 2, 2024, 2:40am

Seems like that, I didn’t have it test thoroughly. Right now it just act as an AP and it works.

Halry · May 2, 2024, 2:51am

I was commented out the code as @frank-w mentioned and had the firmware compiled and right now in my case it works.(I haven’t check if some vlan tagged traffics leak to vlan untagged ones and vice versa which happened in a long time ago openwrt snapshot version)
vlan 1 untagged: home network
vlan 2 tagged: iot network
vlan 3 tagged: guest network

frank-w · May 2, 2024, 10:46am

Would be great if you can some deeper tests as i currently hang on other things

frank-w · May 25, 2024, 6:19am

Have you done more tests here?