I think this is a temporary error and it will be fixed without me
frank-w:
i have this line in place, but no build error…
function is defined in drivers/gpu/drm/rockchip/rockchip_drm_drv.h (rockchip_drm_drv.c) and always build in…maybe you miss an include?
I am using the full set of patches of the entire series along with the latest version of the kernel sources (without intermediate patches). Perhaps the reason for the build error is this. But I know for sure that HDMI works with the latest kernel version and the latest V11 patches on all my rk356x devices.
By the way, I checked DTB for BPIR2pro only with your patches on my 5.18-rc4 core, HDMI works without problems.
frank-w
(Frank W.)
April 30, 2022, 5:50pm
19
hdmi itself works for me too, but not the hdmi-sound which is deferred on hdmi-node i don’t know why. analoge audio soundcard is initialized but left/right channel was mixed in my last test
frank-w:
but not the hdmi-sound
This is a patch that also included HDMI and analog audio on BPIR2pro.
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -6,6 +6,7 @@
/dts-v1/;
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pwm/pwm.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/rockchip.h>
#include <dt-bindings/soc/rockchip,vop2.h>
@@ -16,7 +17,7 @@
compatible = "rockchip,rk3568-bpi-r2pro", "rockchip,rk3568";
aliases {
- ethernet0 = &gmac0;
+ ethernet1 = &gmac1;
mmc0 = &sdmmc0;
mmc1 = &sdhci;
};
@@ -52,6 +53,14 @@
This file has been truncated. show original
But you may need other patches as well.
--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
@@ -183,6 +183,22 @@
};
};
+ hdmi_sound: hdmi-sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,name = "HDMI";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,mclk-fs = <256>;
+ status = "disabled";
+
+ simple-audio-card,codec {
+ sound-dai = <&hdmi>;
+ };
+
+ simple-audio-card,cpu {
+ sound-dai = <&i2s0_8ch>;
+ };
This file has been truncated. show original
etc
frank-w
(Frank W.)
April 30, 2022, 6:36pm
22
I have already
This adds the i2s0 node and an hdmi-sound sound device to the
rk356x device tree. On the rk356[68], the i2s0 controller is
connected...
changed 1 files
with 33 additions
and 0 deletions .
This enables the i2s0 controller and the hdmi-sound node on
the Bananapi R2 Pro single-board computer.
Signed-off-by: Frank Wunderlich <[email protected] >
changed 1 files
with 9 additions
and 0 deletions .
And for analog:
2-channel is working:
speaker-test -Dhw:CARD=Analog,DEV=0 -c2 -t wav
4-channel output is not mapped to stereo (rear not hearable)
speaker-test -Dhw:CARD=Analog,DEV=0 -c4 -t wav
record works...
changed 1 files
with 49 additions
and 2 deletions .
Wonder you have patch for switch…this needs modified driver to work…see my patches on patchwork
frank-w
(Frank W.)
May 5, 2022, 6:00pm
23
got hdmi and analog audio and rtc (found by driver after patch from peter) working:
last state (branches in my repo):
hdmi: 5.18-r2pro-hdmiv11
switch (mt7531): 5.18-mt7531-mainline2 (currently limited to 100M RX on r2pro by port5)
pcie3: 5.18-r2pro-pcie3-mainline3
2 Likes
zuowei8
(zuowei8)
May 10, 2022, 3:16am
24
hi frank-w,
Can linux-5.18 kernel support MT7531’s DSA feature, we hope that R2pro can support it. many peoples are
frank-w
(Frank W.)
May 10, 2022, 5:02am
25
I have it basicly working,but not yet merged for 5.18. Try to get this state in 5.19. Mainline has still fixed CPU-port (6) which needs changes (currently reviewd by dsa maintainer but not yet mtk).
But it looks like there is something wrong in rgmii setup as tx on cpu-port is only 100mbit/s
zuowei8:
many peoples are
what do you mean here?
frank-w
(Frank W.)
May 14, 2022, 1:57pm
26
have sent out v3 for pcie3-support
https://patchwork.kernel.org/project/linux-rockchip/list/?series=641646
@balbes150 , maybe you want to include it into your armbian
Hi frank-w,
I’m trying to make it work OpenWrt on 5.18, not having the device,wonder if can boot with the quartz64 dtb.
frank-w
(Frank W.)
May 14, 2022, 5:23pm
28
do not use another dtb as iodomain will differ and may brick your board!
you’ll find the right dts-patches in my kernel-repo
I was referring to the u-boot , now I found your patches, I see you are using the evb.dts ,I will update that.
frank-w
(Frank W.)
May 14, 2022, 6:05pm
30
Yes,but this is save only if iodomain is not set…uboot does not set it in dts and not in code, so dts can be used.
Evb have same config for basic function like sd/emmc/clocks/main pinctrl like r2pro,so it can be used here…enough for bootup
Btw. This thread is about linux,not uboot
I’ll check out a new set of patches and create new versions of the images.
frank-w
(Frank W.)
June 27, 2022, 7:32am
33
Seems like upper usb-port is broken in 5.19,have not found out why (works in 5.18-main).already set drd-role back to host,but does not fix.
At least pcie ranges are now good without gap, wait for response on bindings and then send out new version with adding missing pinctrl.
I checked the latest version 5.19-rc5 with this set of patches (pay attention to patches 200 and 181) with them, USB works on two ports.
By the way, I’m currently downloading new images with kernel 5.19 for BPIR2pro where USB works.
frank-w
(Frank W.)
July 5, 2022, 12:21pm
35
Thx,200 looks indeed interesting
This patch was published earlier in the patchword.
frank-w
(Frank W.)
July 5, 2022, 6:59pm
37
Can you point to the patch in patchwork?
It seems a revert of this fix
https://www.spinics.net/lists/stable/msg556940.html
And additional change (i guess dropping initialization value does not change anything)
Edit this fixes usb issue:
https://patchwork.kernel.org/project/linux-rockchip/patch/[email protected] /
And of course the dts patch needed you’ll already have and i pushed to mainline today
https://patchwork.kernel.org/project/linux-rockchip/patch/[email protected] /