BPI-R2 SPI Communication

Ryder.Lee · March 14, 2018, 7:33am

What’s your pinmux in dts? You can add some debug logs in tools/spi/spidev_test.c or find a scope to measure the signal to check what happened here.

asprakash · March 14, 2018, 8:40am

Hi. I am using the kernel built by @frank-w and I believe he already use this dts, https://github.com/frank-w/BPI-R2-4.4/blob/master/linux-mt/arch/arm/boot/dts/mt7623n-bpi-r2.dts

frank-w · March 14, 2018, 12:07pm

The last 4.4.120 uses this dts. Same problem in 4.14. Spidev available but no data send/received.

Did the spidev-test-application send data (which can be looped by wiring mosi to miso) or must this be done externally?

asprakash · March 14, 2018, 12:16pm

For me, I tested your 4.4.120 kernel and looped MISO & MOSI. No data send/received. BTW, can you look at this link for SPI and anything useful for us?, https://github.com/LeMaker/LNcommon

I am hardly waiting for @linkerosa kernel and he reported the MISO/MOSI loop test successfully.

TIA.

frank-w · March 14, 2018, 4:00pm

BTW, can you look at this link for SPI and anything useful for us?, https://github.com/LeMaker/LNcommon

i see nothing which will help us getting spi running there

Ryder.Lee · March 15, 2018, 6:27am

Add a real spi device (panel)
Write/read register via spi transfer
Let’s see what happens

asprakash · March 15, 2018, 12:42pm

I already tested with real SPI device. No data read/write.

Ryder.Lee · March 19, 2018, 7:06am

Capture

This is spidev test result on my BPIR2.

Anyway, if you don’t connect anything, you will see something like this:

Capture

asprakash · March 19, 2018, 9:31am

@Ryder.Lee looks promising. Please share your kernel. I will test it on my hardware.

TIA.

frank-w · March 19, 2018, 11:45am

Which kernel,which patches,which config?

Ryder.Lee · March 19, 2018, 1:16pm

The below link (uImage) is based on kernel 4.4 (boot from emmc): https://drive.google.com/file/d/1v4JoOYsPC5MKN_FVnnyCiVg770jOsnNL/view?usp=sharing

Please test it on your spi0 (0x1axxxxx).

frank-w · March 19, 2018, 2:18pm

Can you please show diff between original 4.4 and your version? original 4.4 have no spidev…i tried to add it to my repo,but same result as in 4.14

Else please verify, that my dts(i) and config in 4.14 is correct

github.com

frank-w/BPI-R2-4.14/blob/main/arch/arm/boot/dts/mt7623.dtsi

/*
 * Copyright (c) 2017 MediaTek Inc.
 * Author: John Crispin <[email protected]>
 *	   Sean Wang <[email protected]>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 2 as
 * published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 */

#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/mt2701-clk.h>
#include <dt-bindings/pinctrl/mt7623-pinfunc.h>
#include <dt-bindings/power/mt2701-power.h>

This file has been truncated. show original

github.com

frank-w/BPI-R2-4.14/blob/main/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts

/*
 * Copyright 2017 Sean Wang <[email protected]>
 *
 * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
 */

/dts-v1/;
#include <dt-bindings/input/input.h>
#include "mt7623.dtsi"
#include "mt6323.dtsi"

/ {
	model = "Bananapi BPI-R2";
	compatible = "bananapi,bpi-r2", "mediatek,mt7623";

	aliases {
		serial2 = &uart2;
	};

	chosen {

This file has been truncated. show original

github.com

frank-w/BPI-R2-4.14/blob/main/arch/arm/configs/mt7623n_evb_fwu_defconfig

CONFIG_LOCALVERSION="-bpi-r2"
CONFIG_LOCALVERSION_AUTO=n

#spectre/meltdown
CONFIG_PAGE_TABLE_ISOLATION=y

CONFIG_SYSVIPC=y
CONFIG_IRQ_DOMAIN_DEBUG=y
CONFIG_NO_HZ=y
CONFIG_HIGH_RES_TIMERS=y
CONFIG_CGROUPS=y
CONFIG_NAMESPACES=y

#for lxc
CONFIG_USER_NS=y
CONFIG_MEMCG=y
CONFIG_CGROUP_CPUACCT=y
CONFIG_CGROUP_DEVICE=y
CONFIG_CGROUP_SCHED=y
CONFIG_CPUSETS=y

This file has been truncated. show original

Ryder.Lee · March 20, 2018, 3:09am

The only difference is:

CONFIG_SPI=y CONFIG_SPI_MT65XX=y CONFIG_SPI_SPIDEV=y

frank-w · March 20, 2018, 5:57am

In official 4.4

In spi0 is disabled

github.com

BPI-SINOVOIP/BPI-R2-bsp/blob/master/linux-mt/arch/arm/boot/dts/mt7623.dtsi

/*
 * Copyright (c) 2016 MediaTek Inc.
 * Author: Sean Wang <[email protected]>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 2 as
 * published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 */

#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/mt2701-clk.h>
#include <dt-bindings/power/mt2701-power.h>
#include <dt-bindings/phy/phy.h>
#include <dt-bindings/reset/mt2701-resets.h>

This file has been truncated. show original

Not enabled and no spidev/pinmux in

github.com

BPI-SINOVOIP/BPI-R2-bsp/blob/master/linux-mt/arch/arm/boot/dts/mt7623n-bpi-r2.dts

/*
 * Copyright (c) 2016 MediaTek Inc.
 * Author: Sean Wang <[email protected]>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 2 as
 * published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 */

/dts-v1/;
#include "mt7623.dtsi"

/ {
	model = "Banana Pi BPI-R2 (MediaTek MT7623N 20170301)";
	compatible = "mediatek,mt7623-evb", "mediatek,mt7623";

This file has been truncated. show original

in 4.14 i have these options set:

CONFIG_SPI=y CONFIG_SPI_MASTER=y CONFIG_SPI_SPIDEV=m CONFIG_SPI_MT65XX=m

But maybe we have forgot to load spi-MT65XX. @asprakash can you please try it?

asprakash · March 20, 2018, 6:12am

@frank-w I can test it out and give you the feedback. May I know which kernel binary I have to use for this testing?.

frank-w · March 20, 2018, 6:33am

4.4.120 or 4.14 above 24

frank-w · March 20, 2018, 3:29pm

strange…that seems not to be the problem:

[16:32] root@bpi-r2:~# modprobe spi                                             
spidev      spi-mt65xx                                                          
[16:32] root@bpi-r2:~# modprobe spi-mt65xx                                      
[16:32] root@bpi-r2:~# modprobe spidev                                          
[16:32] root@bpi-r2:~# ls /dev/spidev0.0                                        
/dev/spidev0.0                                                                  
[16:32] root@bpi-r2:~# ./spidev_test -D /dev/spidev0.0                          
spi mode: 0x0                                                                   
bits per word: 8                                                                
max speed: 500000 Hz (500 KHz)                          
[16:32] root@bpi-r2:~# lsmod                                                    
Module                  Size  Used by                                           
spidev                 20480  0                                                 
mtk_thermal            16384  0                                                 
thermal_sys            61440  1 mtk_thermal                                     
spi_mt65xx             20480  0                                                 
mt6577_auxadc          16384  0                                                 
pwm_mediatek           16384  0                                                 
fuse                  102400  1                                                 
ipv6                  413696  30
[16:33] root@bpi-r2:~# uname -r                                                 
4.14.27-bpi-r2-main

in 4.4.120 i have this build-in SPI_MT65XX [=y]

Linux bpi-r2 4.4.120-BPI-R2-Kernel #26 SMP Mon Mar 12 17:35:53 CET 2018 armv7l  
[16:50] root@bpi-r2:~# modprobe spidev                                          
[16:50] root@bpi-r2:~# ./spidev_test -D /dev/spidev32766.0                      
spi mode: 0x0                                                                   
bits per word: 8                                                                
max speed: 500000 Hz (500 KHz)                                                  
[16:50] root@bpi-r2:~#

did we change anything before (setting the port to SPI-Mode), have you the pinmux added? have i done this right?

Ryder.Lee · March 21, 2018, 1:07am

Actually, whether you do looptest or not, you should see all of these messages (FF FF FF …) in console. So, I don’t think this is a HW issue

frank-w · March 21, 2018, 4:46am

Right

i did in my kernels:

Spi-modules in config

In bpi.dts

enable spi0
add pinmux

asprakash · March 21, 2018, 5:06am

Hi. My test result.

#modprobe spi-mt65xx

Result : lsmod not displayed the spi-mt65xx

#modprobe spidev

Result : lsmod displayed the spidev

#./spidev_test -D /dev/spidev32766.0

spi mode: 0x0

bits per word: 8

max speed: 500000 Hz (500 KHz)

Same result when I looped the MISO/MOSI or not.

@Ryder.Lee I tried to boot your kernel from sdcard. The board is not booting. It should be booted only from mmc?.