Kernel 4.19-rc1 for testers


#21

So if you drop the fbdev patch … everything is okay ?


(Frank W.) #22

currently pushed is only the working official part, but here i don’t get a console over hdmi

but same patch works with the old patches…

compare my 4.19-hdmi with the 4.19-hdmi_new branch


#23

hmm, we won’t add fbdev support to mainline. BTW, you can drop the patch 8/13 which will be removed in v3.

These patches are applied for kernel 4.19 - there are something changes between 4.14 and 4.19.

If you just want to run 4.14 on r2 , you can keep old patches.


(Frank W.) #24

Old patches also work on 4.19 with fbdev (branch 4.19-hdmi)…

So currently my 4.19 (-rc) will use the old patches till fbdev works with the new


#25

I’ve take a look at these patches but couldn’t find any obvious problem. Could you help to diff the new & old MTK drm driver?


(Frank W.) #26

this is the diff between old patches (without fbdev) and the new

hdmi_old2new.diff (27,1 KB)

created by

git diff d830822cd61b60136ec1c418a2da07b5750974e4..bdb1373f5ababaa887fcca19df37207c5458285a

as far as i see:

dtsi:

  • hdmiddc0 misses mediatek,mt2701-hdmi-ddc and order differs, same for cec-node
  • pmu+g3dsys are new in the new patches
  • mmsys, display_components, ovl, rdma0, rdma1, wdma, bls, color, mutex, imgsys, larb1, larb2, jpegdec and hifsys only differs in whitespace
  • dpi0 and hdmi0 moved
  • hdmi_pins_a and hdmi_ddc_pins_a added to dtsi

dts:

hdmi0 gets port1 pin-config changes from

 490 -   hdmi_pin: htplg {
 491 -       pins1 {
 492 -           pinmux = <MT7623_PIN_123_HTPLG_FUNC_HTPLG>;
 493 -           input-enable;
 494 -           bias-pull-down;
 495 -       };
 496 -   };

to

 317 +   hdmi_pins_a: hdmi-default {
 318 +       pins-hdmi {
 319 +           pinmux = <MT7623_PIN_123_HTPLG_FUNC_HTPLG>;
 320 +           input-enable;
 321 +           bias-pull-down;
 322 +       };
 323 +   };

hdmiddc and phy gets new options:

 470 +&hdmiddc0 {
 471 +   pinctrl-names = "default";
 472 +   pinctrl-0 = <&hdmi_ddc_pins_a>;
 473 +   status = "okay";
 474 +};
 475 +
 476 +&hdmi_phy {
 477 +   mediatek,ibias = <0xa>;
 478 +   mediatek,ibias_up = <0x1c>;
 479 +   status = "okay";
 480 +};

in drivers/gpu/drm/mediatek/mtk_dpi.c

i’ve found a possible crash-candidate due to changed structure:

 729 -   dpi->encoder.bridge->encoder = &dpi->encoder;
 730 -   ret = drm_bridge_attach(&dpi->encoder, dpi->encoder.bridge, NULL);
 731 +   ret = drm_bridge_attach(&dpi->encoder, dpi->bridge, NULL);

and here are some changes:

 762 @@ -779,22 +777,13 @@ static int mtk_dpi_probe(struct platform_device *pdev)
 763         return -EINVAL;
 764     }
 765  
 766 -   ep = of_graph_get_next_endpoint(dev->of_node, NULL);
 767 -   if (ep) {
 768 -       bridge_node = of_graph_get_remote_port_parent(ep);
 769 -       of_node_put(ep);
 770 -   }
 771 -   if (!bridge_node) {
 772 -       dev_err(dev, "Failed to find bridge node\n");
 773 -       return -ENODEV;
 774 -   }
 775 -
 776 -   dev_info(dev, "Found bridge node: %pOF\n", bridge_node);
 777 -
 778 -   dpi->encoder.bridge = of_drm_find_bridge(bridge_node);
 779 -   of_node_put(bridge_node);
 780 -   if (!dpi->encoder.bridge)
 781 +   ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0,
 782 +                     NULL, &dpi->bridge);
 783 +   if (ret) {
 784 +       dev_err(dev, "Failed to find panel or bridge: %d\n", ret);
 785         return -EPROBE_DEFER;
 786 +   }
 787 +   dev_info(dev, "Found bridge node: %pOF\n", dpi->bridge);
 788  
 789     comp_id = mtk_ddp_comp_get_id(dev->of_node, MTK_DPI);
 790     if (comp_id < 0) {

fbdev-patch is exactly the same in both branches…had not adjust anything to the new drm-patches

again here i see many dev_info / dev_err which i don’t see in my log…i can’t access debugfs or dmesg because my kernel crashes before…so i only have the serial log…how can i debug it?


#27

So you can see dev_info in the log (with hdmi output) when removing fbdev patch, but if you add fbdev then everything goes wrong?


(Frank W.) #28

With fbdev and tv conected i see only the bootlog with stacktrace…tv stays purple. Without fbdev tv goes black till i start xserver via console (no console on tv…only on serial). afair output on console is same till crash. Need to look in dmesg/debuggs where dev_info is shown.but in case of crash this is not possible

these patches work fine except fbdev…

Have to make full log (dmesg,debugfs) if i’m at home again


#29

Odd. These patches work fine on my R2 (I didn’t add fbdev though) , and no need to start xserver by my self.

mtk_ddp_comp_init()

larb_pdev = of_find_device_by_node(larb_node);
if (!larb_pdev) {
	dev_warn(dev, "Waiting for larb device %pOF\n", larb_node);
	of_node_put(larb_node);
	return -EPROBE_DEFER;
}
of_node_put(larb_node);

comp->larb_dev = &larb_pdev->dev;

Could you add log here to check the content of ‘comp->larb_dev’ ?


(Frank W.) #30

Where should i see this message? Serial console,dmesg or debugfs

Do i have to set an option in cmdline? Or activate DEBUG in code

have done by printk…looks like it is set

[    0.839264] DEBUG: Passed mtk_ddp_comp_init 320                              
[    0.843864] DEBUG: Passed mtk_ddp_comp_init 323 &larb_pdev->dev: deacaa10    
[    0.850991] mediatek-dpi 14014000.dpi: Found bridge node: / 

+       printk(KERN_ALERT "DEBUG: Passed %s %d \n",__FUNCTION__,__LINE__);
        comp->larb_dev = &larb_pdev->dev;
 
+       printk(KERN_ALERT "DEBUG: Passed %s %d &larb_pdev->dev: %x\n",__FUNCTION__,__LINE__,(unsigned int)&larb_pdev->dev);

last line from log looks with old hdmi-patches like this:

[    5.175776] mediatek-dpi 14014000.dpi: Found bridge node: /hdmi@14015000

so bridgenode is not found

looked in build.log after making a full clean and found some warnings about dts-nodes:

arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (reg_format): /dpi@14014000/ports/port@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (reg_format): /dpi@14014000/ports/port@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (avoid_default_addr_size): /dpi@14014000/ports/port@0: Relying on default #address-cells value
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (avoid_default_addr_size): /dpi@14014000/ports/port@0: Relying on default #size-cells value
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (avoid_default_addr_size): /dpi@14014000/ports/port@1: Relying on default #address-cells value
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (avoid_default_addr_size): /dpi@14014000/ports/port@1: Relying on default #size-cells value
drivers/gpu/drm/mediatek/mtk_drm_drv.c:207:15: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  .main_path = mt2712_mtk_ddp_main,
               ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/mediatek/mtk_drm_drv.c:209:14: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  .ext_path = mt2712_mtk_ddp_ext,
              ^~~~~~~~~~~~~~~~~~

4.19-hdmi-new.boot.log (13,1 KB)

./drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h

or do you mean the content of the "comp->larb_dev "?

 89 struct mtk_ddp_comp {
 90     struct clk *clk;
 91     void __iomem *regs;
 92     int irq;
 93     struct device *larb_dev;
 94     enum mtk_ddp_comp_id id;
 95     const struct mtk_ddp_comp_funcs *funcs;
 96 };

include/linux/device.h:

 939 struct device {
 940     struct device       *parent;
 941
 942     struct device_private   *p;
 943
 944     struct kobject kobj;
 945     const char      *init_name; /* initial name of the device */
 946     const struct device_type *type;
 947
 948     struct mutex        mutex;  /* mutex to synchronize calls to
 949                      * its driver.
 950                      */
 951
 952     struct bus_type *bus;       /* type of bus device is on */
 953     struct device_driver *driver;   /* which driver has allocated this
 954                        device */
 955     void        *platform_data; /* Platform specific data, device
 956                        core doesn't touch it */
 957     void        *driver_data;   /* Driver data, set and get with
 958                        dev_set/get_drvdata */
 959     struct dev_links_info   links;
 960     struct dev_pm_info  power;
 961     struct dev_pm_domain    *pm_domain;
 962     ....

how can i printk a struct like this?

the empty message found bridge node “/” brings me to this part of patch (drivers/gpu/drm/mediatek/mtk_dpi.c):

@@ -779,22 +777,13 @@ static int mtk_dpi_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
-       ep = of_graph_get_next_endpoint(dev->of_node, NULL);
-       if (ep) {
-               bridge_node = of_graph_get_remote_port_parent(ep);
-               of_node_put(ep);
-       }
-       if (!bridge_node) {
-               dev_err(dev, "Failed to find bridge node\n");
-               return -ENODEV;
-       }
-
-       dev_info(dev, "Found bridge node: %pOF\n", bridge_node);
-
-       dpi->encoder.bridge = of_drm_find_bridge(bridge_node);
-       of_node_put(bridge_node);
-       if (!dpi->encoder.bridge)
+       ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0,
+                                         NULL, &dpi->bridge);
+       if (ret) {
+               dev_err(dev, "Failed to find panel or bridge: %d\n", ret);
                return -EPROBE_DEFER;
+       }
+       dev_info(dev, "Found bridge node: %pOF\n", dpi->bridge);
 
        comp_id = mtk_ddp_comp_get_id(dev->of_node, MTK_DPI);
        if (comp_id < 0) {

if i replace this part from the old hdmi-patches i got

[    0.794879] [drm] hdmi-audio-codec driver bound to HDMI                                                                         
[    0.803075] DEBUG: Passed mtk_ddp_comp_init 312                                                                                 
[    0.807685] DEBUG: Passed mtk_ddp_comp_init 320                                                                                 
[    0.812301] DEBUG: Passed mtk_ddp_comp_init 323 &larb_pdev->dev: deacaa10                                                       
[    0.819414] DEBUG: Passed mtk_ddp_comp_init 312                                                                                 
[    0.824035] DEBUG: Passed mtk_ddp_comp_init 320                                                                                 
[    0.828621] DEBUG: Passed mtk_ddp_comp_init 323 &larb_pdev->dev: deacaa10                                                       
[    0.835533] DEBUG: Passed mtk_ddp_comp_init 312                                                                                 
[    0.840135] DEBUG: Passed mtk_ddp_comp_init 320                                                                                 
[    0.844734] DEBUG: Passed mtk_ddp_comp_init 323 &larb_pdev->dev: deacaa10                                                       
[    0.851875] mediatek-dpi 14014000.dpi: Found bridge node: /hdmi@14015000                                                        
[    0.859816] mediatek-drm 14000000.dispsys: Adding component match for /ovl@14007000                                             
[    0.867471] mediatek-drm 14000000.dispsys: Adding component match for /rdma@14008000                                            
[    0.875279] mediatek-drm 14000000.dispsys: Adding component match for /color@1400b000                                           
[    0.883160] mediatek-drm 14000000.dispsys: Adding component match for /rdma@14012000                                            
[    0.890981] mediatek-drm 14000000.dispsys: Adding component match for /dpi@14014000                                             
[    0.899220] mediatek-drm 14000000.dispsys: bound 14007000.ovl (ops mtk_disp_ovl_component_ops)                                  
[    0.907814] mediatek-drm 14000000.dispsys: bound 14008000.rdma (ops mtk_disp_rdma_component_ops)                                
[    0.916569] mediatek-drm 14000000.dispsys: bound 1400b000.color (ops mtk_disp_color_component_ops)                              
[    0.925487] mediatek-drm 14000000.dispsys: bound 14012000.rdma (ops mtk_disp_rdma_component_ops)                                
[    0.934239] mediatek-dpi 14014000.dpi: Failed to attach bridge: -22                                                             
[    0.940462] ------------[ cut here ]------------                                                                                
[    0.945069] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/drm_bridge.c:150 drm_bridge_detach+0x6c/0x70                              
[    0.953979] Modules linked in:                                                                                                  
[    0.957020] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.19.0-rc1-bpi-r2-hdmi_new #127                                           
[    0.964796] Hardware name: Mediatek Cortex-A7 (Device Tree)                                                                     
[    0.970351] [<c0114c78>] (unwind_backtrace) from [<c010e848>] (show_stack+0x20/0x24)                                            
[    0.978050] [<c010e848>] (show_stack) from [<c094f524>] (dump_stack+0x94/0xa8)                                                  
[    0.985233] [<c094f524>] (dump_stack) from [<c0128280>] (__warn.part.3+0xcc/0xe8)                                               
[    0.992670] [<c0128280>] (__warn.part.3) from [<c012841c>] (warn_slowpath_null+0x54/0x5c)                                       
[    1.000796] [<c012841c>] (warn_slowpath_null) from [<c04f3dbc>] (drm_bridge_detach+0x6c/0x70)                                   
[    1.009270] [<c04f3dbc>] (drm_bridge_detach) from [<c04f8188>] (drm_encoder_cleanup+0x30/0x94)                                  
[    1.017831] [<c04f8188>] (drm_encoder_cleanup) from [<c0518820>] (mtk_dpi_bind+0x110/0x11c)                                     
[    1.026133] [<c0518820>] (mtk_dpi_bind) from [<c051be44>] (component_bind_all+0x130/0x274)                                      
[    1.034347] [<c051be44>] (component_bind_all) from [<c051535c>] (mtk_drm_bind+0xb0/0x228)                                       
[    1.042475] [<c051535c>] (mtk_drm_bind) from [<c051c3bc>] (try_to_bring_up_master+0x21c/0x2d4)                                  
[    1.051035] [<c051c3bc>] (try_to_bring_up_master) from [<c051c79c>] (component_master_add_with_match+0xec/0x120)                
[    1.061147] [<c051c79c>] (component_master_add_with_match) from [<c05158cc>] (mtk_drm_probe+0x37c/0x4c4)                        
[    1.070569] [<c05158cc>] (mtk_drm_probe) from [<c0525dd0>] (platform_drv_probe+0x58/0xa8)                                       
[    1.078698] [<c0525dd0>] (platform_drv_probe) from [<c0523624>] (really_probe+0x254/0x418)                                      
[    1.086911] [<c0523624>] (really_probe) from [<c0523a0c>] (driver_probe_device+0x88/0x1dc)                                      
[    1.095124] [<c0523a0c>] (driver_probe_device) from [<c0523c90>] (__driver_attach+0x130/0x14c)                                  
[    1.103682] [<c0523c90>] (__driver_attach) from [<c0520ff4>] (bus_for_each_dev+0x84/0xc4)                                       
[    1.111810] [<c0520ff4>] (bus_for_each_dev) from [<c0522e08>] (driver_attach+0x2c/0x30)                                         
[    1.119765] [<c0522e08>] (driver_attach) from [<c0522764>] (bus_add_driver+0x200/0x26c)                                         
[    1.127720] [<c0522764>] (bus_add_driver) from [<c0524a00>] (driver_register+0x84/0x118)                                        
[    1.135761] [<c0524a00>] (driver_register) from [<c0526054>] (__platform_register_drivers+0x84/0x160)                           
[    1.144925] [<c0526054>] (__platform_register_drivers) from [<c0e33cb4>] (mtk_drm_init+0x28/0x2c)                               
[    1.153743] [<c0e33cb4>] (mtk_drm_init) from [<c010304c>] (do_one_initcall+0x64/0x218)                                          
[    1.161614] [<c010304c>] (do_one_initcall) from [<c0e01294>] (kernel_init_freeable+0x288/0x318)                                 
[    1.170260] [<c0e01294>] (kernel_init_freeable) from [<c0964b18>] (kernel_init+0x18/0x124)                                      
[    1.178473] [<c0964b18>] (kernel_init) from [<c01010e8>] (ret_from_fork+0x14/0x2c)                                              
[    1.185991] Exception stack(0xde8fbfb0 to 0xde8fbff8)                                                                           
[    1.191008] bfa0:                                     00000000 00000000 00000000 00000000                                       
[    1.199133] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000                                       
[    1.207256] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000                                                         
[    1.213877] ---[ end trace 41b12d43363e3c83 ]---                                                                                
[    1.218480] mediatek-drm 14000000.dispsys: failed to bind 14014000.dpi (ops mtk_dpi_component_ops): -22                         
[    1.227989] mediatek-drm 14000000.dispsys: master bind failed: -22                                                              
[    1.234230] mediatek-drm: probe of 14000000.dispsys failed with error -22   

but the system starts till login-prompt (not hang on this oops)

resettet my git to the point without fbdev to look if there also the bridge is not recognized…

[    0.796240] [drm] hdmi-audio-codec driver bound to HDMI                                                                         
[    0.805356] mediatek-dpi 14014000.dpi: Found bridge node: /                                                                     
[    0.812205] mediatek-drm 14000000.dispsys: Adding component match for /ovl@14007000                                             
[    0.819846] mediatek-drm 14000000.dispsys: Adding component match for /rdma@14008000                                            
[    0.827652] mediatek-drm 14000000.dispsys: Adding component match for /color@1400b000                                           
[    0.835537] mediatek-drm 14000000.dispsys: Adding component match for /rdma@14012000                                            
[    0.843370] mediatek-drm 14000000.dispsys: Adding component match for /dpi@14014000                                             
[    0.851615] mediatek-drm 14000000.dispsys: bound 14007000.ovl (ops mtk_disp_ovl_component_ops)                                  
[    0.860214] mediatek-drm 14000000.dispsys: bound 14008000.rdma (ops mtk_disp_rdma_component_ops)                                
[    0.868966] mediatek-drm 14000000.dispsys: bound 1400b000.color (ops mtk_disp_color_component_ops)                              
[    0.877885] mediatek-drm 14000000.dispsys: bound 14012000.rdma (ops mtk_disp_rdma_component_ops)                                
[    0.886651] mediatek-drm 14000000.dispsys: bound 14014000.dpi (ops mtk_dpi_component_ops)                                       
[    0.894886] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).                                                         
[    0.901456] [drm] No driver support for vblank timestamp query.                                                                 
[    0.907799] [drm] Initialized mediatek 1.0.0 20150513 for 14000000.dispsys on minor 0  

no crash, but bridgenode is “/”


(Frank W.) #31

@ryder.lee have you take a look into it? it seems that xserver not needs all components of drm-driver, but fbdev does

any idea how to fix the missing/wrong bridge-node?


#32

So, you take the 4.19 new patchset without fbdev the output was:

mediatek-dpi 14014000.dpi: Found bridge node: /hdmi

with fbdev:

mediatek-dpi 14014000.dpi: Found bridge node: /


(Frank W.) #33

See last log,with new patches bridgenode is always /…only the hdmi if using (partial) the old patches

Is maybe this patch related: https://patchwork.kernel.org/patch/10596751/


(onon) #34

Hello @frank-w

I’m trying to make Wireguard to run on Banana PI R2. I was able to install it, but when I try to run it, it says that “Operation not permitted”.

I’m guessing that the kernel modules are missing on the 4.4.70. (That’s what I’m running on Ubuntu). Could you confirm that your kernel compilation has or has not the follwoing modules (https://www.wireguard.com/install/#kernel-requirements):

CONFIG_NET
CONFIG_INET
CONFIG_NET_UDP_TUNNEL
CONFIG_CRYPTO_BLKCIPHER

Thanks


(Frank W.) #35

last 2 are not included, but you can add them easily

here is my current config for 4.14:


(onon) #36

I’m getting the following error when trying to compile. Any clue? Sorry the n00b questions.

Build Kernel Cleanup Kernel Build scripts/kconfig/conf --silentoldconfig Kconfig *

  • Restart config…
  • Linux/arm 4.14.69 Kernel Configuration

Maximum PAGE_SIZE order of alignment for DMA IOMMU buffers (ARM_DMA_IOMMU_ALIGNMENT) [8] (NEW) aborted!

Console input/output is redirected. Run ‘make oldconfig’ to update configuration.

scripts/kconfig/Makefile:38: recipe for target ‘silentoldconfig’ failed Makefile:516: recipe for target ‘silentoldconfig’ failed make[2]: *** [silentoldconfig] Error 1 make[1]: *** [silentoldconfig] Error 2 make: *** No rule to make target ‘include/config/auto.conf’, needed by ‘include/config/kernel.release’. Stop. Build CryptoDev make -C M=/home/onon/BPI-R2-4.14/cryptodev/cryptodev-linux ARCH=arm CROSS_COMPILE=ccache arm-linux-gnueabihf- clean make[1]: *** M=/home/onon/BPI-R2-4.14/cryptodev/cryptodev-linux: No such file or directory. Stop. Makefile:39: recipe for target ‘clean’ failed make: *** [clean] Error 2 make -C /home/onon/BPI-R2-4.14 M=/home/onon/BPI-R2-4.14/cryptodev/cryptodev-linux ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- modules make[1]: Entering directory ‘/home/onon/BPI-R2-4.14’

ERROR: Kernel configuration is invalid. include/generated/autoconf.h or include/config/auto.conf are missing. Run ‘make oldconfig && make prepare’ on kernel src to fix it.

WARNING: Symbol version dump ./Module.symvers is missing; modules will have no dependencies and modversions.

CC [M] /home/onon/BPI-R2-4.14/cryptodev/cryptodev-linux/ioctl.o In file included from :0:0: ././include/linux/kconfig.h:5:32: fatal error: generated/autoconf.h: No such file or directory compilation terminated. scripts/Makefile.build:328: recipe for target ‘/home/onon/BPI-R2-4.14/cryptodev/cryptodev-linux/ioctl.o’ failed make[2]: *** [/home/onon/BPI-R2-4.14/cryptodev/cryptodev-linux/ioctl.o] Error 1 Makefile:1527: recipe for target ‘module/home/onon/BPI-R2-4.14/cryptodev/cryptodev-linux’ failed make[1]: *** [module/home/onon/BPI-R2-4.14/cryptodev/cryptodev-linux] Error 2 make[1]: Leaving directory ‘/home/onon/BPI-R2-4.14’ Makefile:27: recipe for target ‘build’ failed make: *** [build] Error 2


(Frank W.) #37
./build.sh importconfig
./build.sh config
#add your option here in nenuconfig
./build.sh

You can search with / in menuconfig to show path and depencies

You can also add your option to defconfig,but thos will get overridden if you check out repo again

But please make separate thread because that has nothing todo with 4.19-rc testing


(Frank W.) #38

@Ryder.Lee have you understand, that problem is also in official patches and only shows up when using fbdev? hdmi-node will not be found with new patches…

btw. how about the pci-error?

 [    1.638106] mtk-pcie 1a140000.pcie: Port0 link down                                                                                                                             
[    1.673461] mtk-pcie 1a140000.pcie: PCI host bridge to bus 0000:00                                                                                                              
[    1.679647] pci_bus 0000:00: root bus resource [io  0x0000-0xffff] (bus address [0x1a160000-0x1a16ffff])                                                                        
[    1.689085] pci_bus 0000:00: root bus resource [mem 0x60000000-0x6fffffff]                                                                                                      
[    1.695917] pci_bus 0000:00: root bus resource [bus 00-ff]                                                                                                                      
[    1.701593] pci 0000:00:01.0: [14c3:0801] type 01 class 0x060400                                                                                                                
[    1.707595] pci 0000:00:01.0: reg 0x14: [mem 0x00000000-0x0000ffff]                                                                                                             
[    1.708083] usb 3-1: new low-speed USB device number 2 using xhci-mtk                                                                                                           
[    1.713895] pci 0000:00:01.0: supports D1                                                                                                                                       
[    1.724207] pci 0000:00:01.0: PME# supported from D0 D1 D3hot                                                                                                                   
[    1.732900] PCI: bus0: Fast back to back transfers disabled                                                                                                                     
[    1.738470] pci 0000:00:01.0: bridge configuration invalid ([bus 00-00]), reconfiguring                                                                                         
[    1.746574] pci 0000:01:00.0: [1b21:0611] type 00 class 0x010185                                                                                                                
[    1.752591] pci 0000:01:00.0: reg 0x10: initial BAR value 0x00000000 invalid                                                                                                    
[    1.759607] pci 0000:01:00.0: reg 0x10: [io  size 0x0008]                                                                                                                       
[    1.764977] pci 0000:01:00.0: reg 0x14: initial BAR value 0x00000000 invalid                                                                                                    
[    1.771992] pci 0000:01:00.0: reg 0x14: [io  size 0x0004]                                                                                                                       
[    1.777362] pci 0000:01:00.0: reg 0x18: initial BAR value 0x00000000 invalid                                                                                                    
[    1.784375] pci 0000:01:00.0: reg 0x18: [io  size 0x0008]                                                                                                                       
[    1.789758] pci 0000:01:00.0: reg 0x1c: initial BAR value 0x00000000 invalid                                                                                                    
[    1.796759] pci 0000:01:00.0: reg 0x1c: [io  size 0x0004]                                                                                                                       
[    1.802142] pci 0000:01:00.0: reg 0x20: initial BAR value 0x00000000 invalid                                                                                                    
[    1.809156] pci 0000:01:00.0: reg 0x20: [io  size 0x0010]                                                                                                                       
[    1.814527] pci 0000:01:00.0: reg 0x24: [mem 0x00000000-0x000001ff]                                                                                                             
[    1.820772] pci 0000:01:00.0: reg 0x30: [mem 0x00000000-0x0000ffff pref]                                                                                                        
[    1.827534] pci 0000:01:00.0: 4.000 Gb/s available PCIe bandwidth, limited by 5 GT/s x1 link at 0000:00:01.0 (capable of 7.876 Gb/s with 8 GT/s x1 link)                        
[    1.832059] input: USB USB Keykoard as /devices/platform/1a1c0000.usb/usb1/1-1/1-1:1.0/0003:1C4F:0002.0001/input/input0                                                         
[    1.870917] PCI: bus1: Fast back to back transfers disabled                                                                                                                     
[    1.876469] pci_bus 0000:01: busn_res: [bus 01-ff] end is updated to 01                                                                                                         
[    1.883106] pci 0000:00:01.0: BAR 8: assigned [mem 0x60000000-0x600fffff]                                                                                                       
[    1.889876] pci 0000:00:01.0: BAR 9: assigned [mem 0x60100000-0x601fffff pref]                                                                                                  
[    1.897055] pci 0000:00:01.0: BAR 1: assigned [mem 0x60200000-0x6020ffff]                                                                                                       
[    1.903829] pci 0000:00:01.0: BAR 7: assigned [io  0x1000-0x1fff]                                                                                                               
[    1.905523] input:  USB OPTICAL MOUSE as /devices/platform/1a240000.usb/usb3/3-1/3-1:1.0/0003:15D9:0A4C.0002/input/input1                                                       
[    1.909923] pci 0000:01:00.0: BAR 6: assigned [mem 0x60100000-0x6010ffff pref]                                                                                                  
[    1.921349] evbug: Connected device: input0 (USB USB Keykoard at usb-1a1c0000.usb-1/input0)                                                                                     
[    1.927991] pci 0000:01:00.0: BAR 5: assigned [mem 0x60000000-0x600001ff]                                                                                                       
[    1.936509] hid-generic 0003:1C4F:0002.0001: input,hidraw0: USB HID v1.10 Keyboard [USB USB Keykoard] on usb-1a1c0000.usb-1/input0                                              
[    1.943057] pci 0000:01:00.0: BAR 4: assigned [io  0x1000-0x100f]                                                                                                               
[    1.959157] input: USB USB Keykoard Consumer Control as /devices/platform/1a1c0000.usb/usb1/1-1/1-1:1.1/0003:1C4F:0002.0003/input/input2                                        
[    1.960801] pci 0000:01:00.0: BAR 0: assigned [io  0x1010-0x1017]                                                                                                               
[    1.979026] pci 0000:01:00.0: BAR 2: assigned [io  0x1018-0x101f]                                                                                                               
[    1.985084] pci 0000:01:00.0: BAR 1: assigned [io  0x1020-0x1023]                                                                                                               
[    1.991155] pci 0000:01:00.0: BAR 3: assigned [io  0x1024-0x1027]                                                                                                               
[    1.997213] pci 0000:00:01.0: PCI bridge to [bus 01]                                                                                                                            
[    2.002162] pci 0000:00:01.0:   bridge window [io  0x1000-0x1fff]                                                                                                               
[    2.008232] pci 0000:00:01.0:   bridge window [mem 0x60000000-0x600fffff]                                                                                                       
[    2.014976] pci 0000:00:01.0:   bridge window [mem 0x60100000-0x601fffff pref]

#39

As my R2 with the new patches (without fbdev) could show GNOME normally, I didn’t notice ‘hdmi-node will not be found’ before since

btw. how about the pci-error?

How will the error impact on a pci device (link status and behavior …)?


(Frank W.) #40

Are you try to find the cause? The dts-warnings i find strange…

arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (reg_format): /dpi@14014000/ports/port@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)       

arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (reg_format): /dpi@14014000/ports/port@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) 


+&dpi0 {
+	status = "okay";
+
+	ports {
+		port@0 {
+			reg = <0>;
+			dpi0_out: endpoint {
+				remote-endpoint = <&hdmi0_in>;
+			};
+		};
+
+		port@1 {
+			reg = <1>;
+			dpi0_in: endpoint {
+				remote-endpoint = <&bls_out>;
+			};
+		};
+	};
+};
+
-&dpi0 {
-	status = "okay";
-	port {
-		dpi0_out: endpoint {
-			remote-endpoint = <&hdmi0_in>;
-		};
-
-		dpi0_in: endpoint@1 {
-			remote-endpoint = <&bls_out>;
-		};
-	};
-};

 &hdmi0 {
-	status = "okay";
 	pinctrl-names = "default";
-	pinctrl-0 = <&hdmi_pin>;
+	pinctrl-0 = <&hdmi_pins_a>;
+	status = "okay";
+
 	ports {
 		#address-cells = <1>;
 		#size-cells = <0>;
@@ -260,9 +272,28 @@
 				remote-endpoint = <&dpi0_out>;
 			};
 		};
+
+		port@1 {
+			reg = <1>;
+			hdmi0_out: endpoint {
+				remote-endpoint = <&hdmi_connector_in>;
+			};
+		};
 	};
 };

this size-/address-options are not set to dsi-ports in both versions

also i noticed a additional level in dpi-node and second port:

old:

&dpi0 {
	status = "okay";
	port {
		dpi0_out: endpoint { //<<<<<< dpi0_out is here is 2 level below dpi-node
			remote-endpoint = <&hdmi0_in>;
		};

		dpi0_in: endpoint@1 {
			remote-endpoint = <&bls_out>;
		};
	};
};

new:

&dpi0 {
	status = "okay";

	ports {
		port@0 {
			reg = <0>;
			dpi0_out: endpoint { //<<<<<< dpi0_out is here is 3 level below dpi-node (additional port@x-level)
				remote-endpoint = <&hdmi0_in>;
			};
		};
//additional port
		port@1 {
			reg = <1>;
			dpi0_in: endpoint {
				remote-endpoint = <&bls_out>;
			};
		};
	};
};

for pcie i have plugged in a pci-card and it was detected on 4.19 like on 4.14…but it seems i did not have the driver for it compiled in and currently i have no clue, how i can create a wifi-client-connection without wpa_suplicant

root@bpi-r2-ubuntu:~# lspci                                                                                                                                              
00:00.0 PCI bridge: MEDIATEK Corp. Device 0801 (rev 01)                                                                                                                  
00:01.0 PCI bridge: MEDIATEK Corp. Device 0801 (rev 01)                                                                                                                  
01:00.0 Network controller: Intel Corporation Centrino Ultimate-N 6300 (rev 35)                                                                                          
02:00.0 IDE interface: ASMedia Technology Inc. ASM1061 SATA IDE Controller (rev 02)

[   11.519660] Intel(R) Wireless WiFi driver for Linux                                                                                                                   
[   11.519669] Copyright(c) 2003- 2015 Intel Corporation                                                                                                                 
[   11.519891] iwlwifi 0000:01:00.0: enabling device (0140 -> 0142)                                                                                                      
[   11.520098] iwlwifi 0000:01:00.0: pci_enable_msi failed - -22                                                                                                         
[   11.528002] iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-6000-6.ucode failed with error -2                                                                  
[   11.528058] iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-6000-5.ucode failed with error -2                                                                  
[   11.528096] iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-6000-4.ucode failed with error -2                                                                  
[   11.528108] iwlwifi 0000:01:00.0: no suitable firmware found!                                                                                                         
[   11.533942] iwlwifi 0000:01:00.0: minimum version required: iwlwifi-6000-4                                                                                            
[   11.540794] iwlwifi 0000:01:00.0: maximum version supported: iwlwifi-6000-6                                                                                           
[   11.547822] iwlwifi 0000:01:00.0: check git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git

ok, after installing linux-firmware i got a wifi-device:

8: wlp1s0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000                                                                                  
    link/ether 00:24:d7:c3:e5:74 brd ff:ff:ff:ff:ff:ff                               

but imho wpa_supplicant is need for a wpa2-client connection, or is there another way? wpa-supplicant causes internal wifi-driver to crash